Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Travis-CI tests #56

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update Travis-CI tests #56

wants to merge 5 commits into from

Conversation

larsgw
Copy link
Contributor

@larsgw larsgw commented Jul 12, 2018 •
edited
Loading

Includes:

  • Updates in Node (essential) & Ruby versions (2e28fb7, 83f2f65)
  • Update test suite code, making it run again (2b433fe)
  • Making test suite output more readable (11c1e05)
    • colour-coding PASS/WARN/ERROR
    • inserting newlines between scrapers
    • hiding quickscrapes logging - maybe a flag would be nice for this
  • Fix coverage code (8f29ec4)
    • basic fixes, making not everything return 0 again
    • added criterium, checking if values are empty (if they are, they aren't tested; dummy values would still count towards coverage)

larsgw added 5 commits July 12, 2018 20:30
@larsgw
Update Travis-CI node version
2e28fb7
@larsgw
Update Travis-CI ruby version
83f2f65
@larsgw
Update tests
2b433fe
@larsgw
Add spacing and colouring to tests
11c1e05
@larsgw
Fix coverage
8f29ec4 
Before, coverage was 0 all round.

Added another criterium: values shouldn't be
empty. If they can be, any value is
automatically counted, even if it isn't found.
When testing, a property "foo" was added, without
any sensible target. Naturally, this returned
nothing. However, it still counted towards the
coverage total.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@larsgw